[PATCH] JDK-8167368 Leftover: get_source.sh in build documentation (original) (raw)
Sergey merkel05 at gmail.com
Thu Nov 15 15:41:32 UTC 2018
- Previous message (by thread): [PATCH] JDK-8167368 Leftover: get_source.sh in build documentation
- Next message (by thread): [PATCH] JDK-8167368 Leftover: get_source.sh in build documentation
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Erik, David,
Thanks for review comments! I've almost addressed them, however, I have a question worth asking before finalizing a patch.
At the building.md:1396 [1] (as well as in it's html alter-ego) there's a section:
### Setting Up a Forest for Pushing Changes (defpath)
I believe it is obsolete and could be safely deleted, or am I missing something?
And one more thing about the patches themselves. As patches aren't that compact anymore, should I send updated diffs for building.md && building.html in the separate mails, or it will be fine if I just inline them alltogether?
Thanks, su -
[1] http://hg.openjdk.java.net/jdk/sandbox/file/a2413ed39eff/doc/building.md#l1396
- Previous message (by thread): [PATCH] JDK-8167368 Leftover: get_source.sh in build documentation
- Next message (by thread): [PATCH] JDK-8167368 Leftover: get_source.sh in build documentation
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]