RFR(XXS): 8214007: Fix sun.awt.nativedebug on X11 platforms (original) (raw)
Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Mon Nov 19 12:28:22 UTC 2018
- Previous message (by thread): RFR(XXS): 8214007: Fix sun.awt.nativedebug on X11 platforms
- Next message (by thread): RFR 4947890 : Minimize JNI upcalls in system property initialization
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 2018-11-16 19:08, Volker Simonis wrote:
Hi,
can I please have a review for the following trivial fix: http://cr.openjdk.java.net/~simonis/webrevs/2018/8214007/ https://bugs.openjdk.java.net/browse/JDK-8214007 Looks good to me.
(But this mess, oh this mess...)
/Magnus
AWT supports some kind of native logging which can be enabled with "-Dsun.awt.nativedebug=true -Dawtdebug.ctrace=true". Unfortunately this doesn't work on X platforms any more because both, libawt and libawtxawt end up with a copy of debugtrace.o. Among others, debugtrace.o contains the static variable GlobalTracingEnabled which denotes the tracing state. This obviously can't work if the final executable contains several instances of this variable. The fix is trivial. Remove "common/awt/debug" from the set of sources for libawtxawt. libawtxawt is linked against libawt (which already contains debugtrace.o) anyway, so this is no problem. Thank you and best regards, Volker
- Previous message (by thread): RFR(XXS): 8214007: Fix sun.awt.nativedebug on X11 platforms
- Next message (by thread): RFR 4947890 : Minimize JNI upcalls in system property initialization
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]