RFR: 8214045: Missing explicit dependencies of build-microbenchmark cause intermittent build failure (original) (raw)

David Holmes david.holmes at oracle.com
Mon Nov 19 12:34:52 UTC 2018


+1

Thanks Claes!

David

On 19/11/2018 10:14 pm, Magnus Ihse Bursie wrote:

On 2018-11-19 12:10, Claes Redestad wrote:

Hi,

we're seeing a few rare, intermittent build failures on some older machines due missing explicit dependencies on some modules (such as java.xml). While more fine-grained option exists, we might as well depend on exploded-image to ensure that microbenchmarks are always free to compile against code from the entire JDK. Bug: https://bugs.openjdk.java.net/browse/JDK-8214045 Patch is trivial and inlined below. Thanks! /Claes diff -r 16609197022c make/Main.gmk --- a/make/Main.gmk    Fri Nov 16 23:39:51 2018 +0100 +++ b/make/Main.gmk    Mon Nov 19 11:58:46 2018 +0100 @@ -793,7 +793,7 @@ jrtfs-jar: interim-langtools -  build-microbenchmark: interim-langtools jdk.unsupported java.management +  build-microbenchmark: interim-langtools exploded-image ifeq ($(ENABLEGENERATECLASSLIST), true) ifeq ($(CREATEBUILDJDK), true) Looks good to me. /Magnus



More information about the build-dev mailing list