RFR(S): 8214343: Handle the absence of Xrandr more generically (original) (raw)
Erik Joelsson erik.joelsson at oracle.com
Tue Nov 27 16:45:42 UTC 2018
- Previous message (by thread): RFR(S): 8214343: Handle the absence of Xrandr more generically
- Next message (by thread): RFR(S): 8214343: Handle the absence of Xrandr more generically
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Looks ok to me.
/Erik
On 2018-11-27 05:52, Volker Simonis wrote:
Hi,
can I please have a review for the following trivial change which handles the absence of Xrandr more generically: http://cr.openjdk.java.net/~simonis/webrevs/2018/8214343/ https://bugs.openjdk.java.net/browse/JDK-8214343 Change JDK-8213944 fixed the build on AIX (which has no Xrandr) by conditionally excluding the relevant parts on AIX with the help of preprocessor defines. On the mailing lists the wish was expressed to handle the absence of Xrandr more generically during the configure step, so here comes the corresponding change. In contrast to the suggestions on the previous mail thread I define "NOXRENDER" if we're configuring on AIX. This avoids clobbering all the other platforms which support Xrandr with yet another command line define of the form "-DHAVEXRANDR". Instead, only the corresponding compiler options on AIX will now contain "-DNOXRANDR". Other platforms which don't support Xrandr can now easily define NOXRANDR as well. Thank you and best regards, Volker
- Previous message (by thread): RFR(S): 8214343: Handle the absence of Xrandr more generically
- Next message (by thread): RFR(S): 8214343: Handle the absence of Xrandr more generically
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]