RFR 4947890 : Minimize JNI upcalls in system property initialization (original) (raw)
Roger Riggs Roger.Riggs at oracle.com
Tue Nov 27 21:00:31 UTC 2018
- Previous message (by thread): RFR 4947890 : Minimize JNI upcalls in system property initialization
- Next message (by thread): RFR 4947890 : Minimize JNI upcalls in system property initialization
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi,
Updated webrev: http://cr.openjdk.java.net/~rriggs/webrev-props-only-raw-4/index.html
Updated defaults for VENDOR, VENDOR_URL, VENDOR_URL_BUG to: COMPANY_NAME=N/A VENDOR_URL=https://openjdk.java.net/ VENDOR_URL_BUG=https://bugreport.java.com/bugreport/
Added Brent's suggestion to verify FIXED_LENGTH in the test.
Ensure that configure passes the --vendor-... arguments through to initialize the system properties.
Thanks to all the reviewers.
Roger
On 11/26/2018 06:12 PM, Brent Christian wrote:
Hi,
On 11/19/18 3:37 PM, Roger Riggs wrote:
Raw::xxxNDX are initialized to 1 + previousNDX. It's a general good approach to increment the index but I find it error-prone and hard to catch mistake since the (adjacent) variable names look so alike. Perhaps some form of verification or assertion to ensure the indices are correctly initialized. > Added a test that uses reflection to verify the uniqueness and sequence. The test says: * Check that the Raw.*NDX indexes are sequential and followed by the FIXEDLENGTH value. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ though the code does not verify that FIXEDLENGTH is the final value. I don't know that it's all that important to do, but I thought I'd point it out. Thanks, -Brent
- Previous message (by thread): RFR 4947890 : Minimize JNI upcalls in system property initialization
- Next message (by thread): RFR 4947890 : Minimize JNI upcalls in system property initialization
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]