RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32 (original) (raw)

Nick Gasson Nick.Gasson at arm.com
Wed Nov 28 03:25:43 UTC 2018

I missed one thing then looking at this. In TimeZonemd.c it should be #ifdef MACOSX rather than #ifndef. I can sponsor the change for you but I need to change this one line before pushing.

Hi Alan,

Yes feel free to modify it. I think looking at the at other files with these #defines more closely, is it the case that the #ifndef MACOSX check is only required for statvfs64? As in e.g. UnixNativeDispatcher.c. So TimeZone_md.c should look like this:

#if defined(_ALLBSD_SOURCE) #define stat64 stat #define lstat64 lstat #define fstat64 fstat #endif

I don't have access to any OS X machines to test unfortunately.

But I wonder if a better way to handle this is to check for the presence of the stat64 functions in the configure script, and then we could just write something like this, which would be a lot clearer:

#if !defined(HAVE_STAT64) #define stat64 stat #endif

Nick

-----Original Message----- From: Alan Bateman <Alan.Bateman at oracle.com> Sent: 28 November 2018 03:14 To: Nick Gasson <Nick.Gasson at arm.com>; Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com>; build-dev <build-dev at openjdk.java.net>; core-libs-dev at openjdk.java.net Cc: nd <nd at arm.com> Subject: Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

On 26/11/2018 09:08, Nick Gasson wrote: > Hi Alan, > > I've done this here: > > http://cr.openjdk.java.net/~njian/8214077/webrev.3/ > I missed one thing then looking at this. In TimeZonemd.c it should be #ifdef MACOSX rather than #ifndef. I can sponsor the change for you but I need to change this one line before pushing. -Alan

More information about the build-dev mailing list