RFR(S): 8211145: [ppc] [s390]: Build fails due to -Werror=switch (introduced with JDK-8211029) (original) (raw)
Volker Simonis volker.simonis at gmail.com
Mon Oct 1 07:39:48 UTC 2018
- Previous message (by thread): RFR: 8211296: Remove HotSpot deprecation warning suppression for Mac/clang
- Next message (by thread): RFR(S): 8211145: [ppc] [s390]: Build fails due to -Werror=switch (introduced with JDK-8211029)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Lutz,
the change looks good.
Thanks for cleaning this up, Volker
On Fri, Sep 28, 2018 at 12:30 PM Aleksey Shipilev <shade at redhat.com> wrote:
On 09/27/2018 04:28 PM, Schmidt, Lutz wrote: > re break vs. ShouldNotReachHere(), I tried to change semantics as little as possible. After > discussion with colleagues, we concluded that ShouldNotReachHere() is the better choice. Code was > modified accordingly. Your concerns re. coding style are reflected in the new webrev as well. It > can be found here: http://cr.openjdk.java.net/~lucy/webrevs/8211145.02/ Looks good! Ship it. -Aleksey
- Previous message (by thread): RFR: 8211296: Remove HotSpot deprecation warning suppression for Mac/clang
- Next message (by thread): RFR(S): 8211145: [ppc] [s390]: Build fails due to -Werror=switch (introduced with JDK-8211029)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]