[12]RFR: [JDK-8074824]: Resolve disabled warnings for libawt_xawt (original) (raw)
Philip Race philip.race at oracle.com
Mon Oct 1 16:19:39 UTC 2018
- Previous message (by thread): [aarch64-port-dev ] RFR(XS): 8211207: AArch64: Fix build failure after JDK-8211029
- Next message (by thread): [12]RFR: [JDK-8074824]: Resolve disabled warnings for libawt_xawt
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi,
- Has this been built on all platforms ?
- I can't find the list of warnings that you are seeing and fixing and they are all over the place. So adding 2d-dev and build-dev. For each of these changes, please show what was the warning that you received from the compiler This might sound like a lot of work, but it won't be disproportionate and I've made the same request for similar reviews and without it, it is hard to review the changes.
For example (and I do mean just example) http://cr.openjdk.java.net/~kaddepalli/8074824/webrev01/src/java.desktop/unix/native/common/awt/awt_Font.c.udiff.html
why would that not be #ifdef instead ?
- Testing .. did you run at least all our jtreg tests to make sure you didn't break some behaviour ..
-phil.
On 9/29/18, 8:18 PM, Krishna Addepalli wrote:
Hi All, Please review a fix for JDK-8074824: https://bugs.openjdk.java.net/browse/JDK-8074824 Webrev: http://cr.openjdk.java.net/~kaddepalli/8074824/webrev01/ <http://cr.openjdk.java.net/%7Ekaddepalli/8074824/webrev01/> Most of the warnings have been fixed for Linux, Mac and Windows. Thanks, Krishna
- Previous message (by thread): [aarch64-port-dev ] RFR(XS): 8211207: AArch64: Fix build failure after JDK-8211029
- Next message (by thread): [12]RFR: [JDK-8074824]: Resolve disabled warnings for libawt_xawt
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]