RFR(S): 8211350: Remove jprt support (original) (raw)
Mandy Chung mandy.chung at oracle.com
Tue Oct 2 18🔞16 UTC 2018
- Previous message (by thread): RFR(S): 8211350: Remove jprt support
- Next message (by thread): RFR(S): 8211350: Remove jprt support
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
+1
Mandy
On 10/2/18 11:17 AM, Mikael Vidstedt wrote:
Thanks for the reviews. I’ve reverted the changes related to Helper and “just” adjusted the comments instead. webrev: http://cr.openjdk.java.net/~mikael/webrevs/8211350/webrev.01/open/webrev/ <http://cr.openjdk.java.net/%7Emikael/webrevs/8211350/webrev.01/open/webrev/> incremental (from webrev.00): http://cr.openjdk.java.net/~mikael/webrevs/8211350/webrev.01.incr/open/webrev/ <http://cr.openjdk.java.net/%7Emikael/webrevs/8211350/webrev.01.incr/open/webrev/>
Btw, I notice that "Test not run, NO jmods directory” will be printed twice when jmods is missing - once in Helper::newHelper and once in the methods calling it. In general, the handling of a null return from newHelper could use some clean up, but that is out of scope for this change. Cheers, Mikael
- Previous message (by thread): RFR(S): 8211350: Remove jprt support
- Next message (by thread): RFR(S): 8211350: Remove jprt support
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]