[CAUTION] RFR : 8211146 : fix problematic elif-tests after recent gcc warning changes Werror=undef (original) (raw)
serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Wed Oct 3 04:50:45 UTC 2018
- Previous message (by thread): RFR: JDK-8211073 Remove -Wno-extra from Hotspot
- Next message (by thread): RFR: 8210459: Add support for generating compile_commands.json
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
+1 (if you still need it)
Thanks, Serguei
On 9/26/18 4:41 AM, David Holmes wrote:
That all seems fine to me.
Thanks for fixing. David On 26/09/2018 5:48 AM, Langer, Christoph wrote: Hi Matthias,
looks good (and trivial). Ccing serviceability-dev because of change in libjdwp. Best regards Christoph *From:*nio-dev <nio-dev-bounces at openjdk.java.net> *On Behalf Of *Baesken, Matthias Sent: Mittwoch, 26. September 2018 11:25 To: 'build-dev at openjdk.java.net' <build-dev at openjdk.java.net>; net-dev <net-dev at openjdk.java.net>; nio-dev at openjdk.java.net Cc: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; Schmidt, Lutz <lutz.schmidt at sap.com> Subject: [CAUTION] RFR : 8211146 : fix problematic elif-tests after recent gcc warning changes Werror=undef Hello, please review this small build fix . After the recent changes to the gcc compile flags with 8211029 , most of our Linux builds stopped working . Error : === Output from failing command(s) repeated here === * For target supportnativejava.baselibnetDatagramPacket.o: In file included from /OpenJDK/8210319/jdk/src/java.base/share/native/libnet/netutil.h:31:0, from /OpenJDK/8210319/jdk/src/java.base/share/native/libnet/DatagramPacket.c:27: /OpenJDK/8210319/jdk/src/java.base/unix/native/libnet/netutilmd.h:50:7: error: "solaris" is not defined [-Werror=undef] #elif solaris ^ After looking into it, it seems that the jdk/src/java.base/unix/native/libnet/netutilmd.h compile error is only triggered on older Linux OS (e.g. SLES11). Probably that’s why it was not seen at Oracle after puhsing after 8211029 . Some greps showed me a number of similar problematic #elif-checks for OS, I adjusted them too . Bug / webrev : https://bugs.openjdk.java.net/browse/JDK-8211146 http://cr.openjdk.java.net/~mbaesken/webrevs/8211146.0/ <http://cr.openjdk.java.net/%7Embaesken/webrevs/8211146.0/> Thanks, Matthias
- Previous message (by thread): RFR: JDK-8211073 Remove -Wno-extra from Hotspot
- Next message (by thread): RFR: 8210459: Add support for generating compile_commands.json
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]