RFR: 8212004: Optional compile_commands.json field not compatible with older libclang (original) (raw)
Erik Joelsson erik.joelsson at oracle.com
Wed Oct 10 15:34:17 UTC 2018
- Previous message (by thread): RFR: 8212004: Optional compile_commands.json field not compatible with older libclang
- Next message (by thread): RFR: 8212004: Optional compile_commands.json field not compatible with older libclang
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Looks good.
/Erik
On 2018-10-10 07:02, Robin Westberg wrote:
Hi all,
Please review this small change to remove the “output” field from the compilecommands.json file generated by “make compile-commands”. As it turns out, this optional field is incompatible with tooling built on libclang versions older than 4.0. As this field provides no real benefit for us, it can simply be dropped from the output. Issue: https://bugs.openjdk.java.net/browse/JDK-8212004 Webrev: https://cr.openjdk.java.net/~rwestberg/8212004/webrev.00/ Testing: tier1, builds-tier5 Best regards, Robin
- Previous message (by thread): RFR: 8212004: Optional compile_commands.json field not compatible with older libclang
- Next message (by thread): RFR: 8212004: Optional compile_commands.json field not compatible with older libclang
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]