RFR: XXS: JDK-8213102: Oracle Unilinks are [301 Moved Permanently] to https://docs.oracle.com (original) (raw)

Erik Joelsson erik.joelsson at oracle.com
Mon Oct 29 20:05:17 UTC 2018

Looks good.

/Erik

On 2018-10-29 11:57, Jonathan Gibbons wrote:

Please review the following simple fix to change the host for Oracle Unilinks from www.oracle.com to docs.oracle.com to avoid unnecessary redirects.

JBS: https://bugs.openjdk.java.net/browse/JDK-8213102 The fix was done with the following command: grep -rl oracle.com/pls open/make | xargs sed --in-place 's|www.oracle.com/pls|docs.oracle.com/pls|g' -- Jon

Patch inline: $ hg diff -R open diff -r 3152b928769d make/Docs.gmk --- a/make/Docs.gmk     Mon Oct 29 11:05:45 2018 -0700 +++ b/make/Docs.gmk     Mon Oct 29 11:45:11 2018 -0700 @@ -61,7 +61,7 @@ $(SUPPORTOUTPUTDIR)/rmic/* $(TOPDIR)/src/*/share/doc/stub)  # URLs -JAVADOCBASEURL := https://www.oracle.com/pls/topic/lookup?ctx=javase$(VERSIONNUMBER)&id=homepage +JAVADOCBASEURL := https://docs.oracle.com/pls/topic/lookup?ctx=javase$(VERSIONNUMBER)&id=homepage  BUGSUBMITURL := https://bugreport.java.com/bugreport/  COPYRIGHTURL := {@docroot}/../legal/copyright.html  LICENSEURL := https://www.oracle.com/technetwork/java/javase/terms/license/java$(VERSIONNUMBER)speclicense.html diff -r 3152b928769d make/jdk/src/classes/build/tools/taglet/ExtLink.java --- a/make/jdk/src/classes/build/tools/taglet/ExtLink.java Mon Oct 29 11:05:45 2018 -0700 +++ b/make/jdk/src/classes/build/tools/taglet/ExtLink.java Mon Oct 29 11:45:11 2018 -0700 @@ -48,7 +48,7 @@ * will produce the following html *

* {@code - * Please see a spectacular sight. + * Please see a spectacular sight. * } */  public class ExtLink implements Taglet { @@ -63,7 +63,7 @@ static final String TAGNAME = "extLink"; -    static final String URL = "https://www.oracle.com/pls/topic/lookup?ctx=javase" + +    static final String URL = "https://docs.oracle.com/pls/topic/lookup?ctx=javase" + SPECVERSION + "&id="; static final Pattern TAGPATTERN = Pattern.compile("(?s)(\s*)(?\w+)(\s+)(?.*)$");

More information about the build-dev mailing list