Review request: update javac to properly output mandated parameters in MethodParameters attributes (original) (raw)

Eric McCorkle eric.mccorkle at oracle.com
Fri Feb 8 13:20:00 PST 2013

I've updated the webrev.

The extra parameters are now generated with SYNTHETIC flags set by default, except when they match the three cases in the spec ("name" parameter of an Enum's valueOf, the first parameter of an anonymous constructor, or the first parameter of a non-private inner member class).

I've tested these using the examples from Peter Jensen's test suite.

Please look over the new webrev and comment.

Thanks, Eric

On 02/06/13 12:23, Eric McCorkle wrote:

Hello,

Please review the following patch, which updates javac to output mandated parameters in MethodParameters attributes. It also updates javac to reflect spec changes, namely the definition of the ACCMANDATED flag. The webrev is here: http://cr.openjdk.java.net/~emc/8006345/ This patch addresses the following issues: http://bugs.sun.com/viewbug.do?bugid=8006345 http://bugs.sun.com/viewbug.do?bugid=8006896 http://bugs.sun.com/viewbug.do?bugid=8006345 The latest version of the spec for parameter reflection can be found here: http://cr.openjdk.java.net/~abuckley/8misc.pdf Thanks, Eric -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 314 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130208/7db935ee/eric_mccorkle.vcf

More information about the compiler-dev mailing list