Review request: update javac to properly output mandated parameters in MethodParameters attributes (original) (raw)

Eric McCorkle eric.mccorkle at oracle.com
Tue Feb 12 08:17:40 PST 2013

Maybe make the one for ClassSymbol take a ClassSymbol as an argument as opposed to a Symbol?

On 02/12/13 10:52, Maurizio Cimadamore wrote:

On 12/02/13 14:53, Eric McCorkle wrote:

No, actually, that variant has to be there in order to add the outer this field in a ClassSymbol. The overloading on Symbol/MethodSymbol is very hard to parse - i.e. it's hard to tell whether a client would call one or the other. What I'm suggesting is that, since both methods seem to share 99% of the code, you add the extra logic to the old method guarded by a check (which I think is sym.kind == MTH - i.e. if the symbl is a method). Maurizio -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 314 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130212/79f578c6/eric_mccorkle.vcf

More information about the compiler-dev mailing list