Review request for JDK-8008658: Four new method param jtreg tests fail in nightly tests (original) (raw)

Eric McCorkle eric.mccorkle at oracle.com
Thu Feb 21 10:12:30 PST 2013

Hello,

Please review this patch, which corrects jtreg failures. The root cause of this failure is a bit complicated... It the result of an improper merge of two patches.

The following patch implemented the new format in javac: http://cr.openjdk.java.net/~emc/8006948/webrev.01/src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java.sdiff.html

Note that it converts two appendInt calls to appendChar.

I had previously committed this patch: http://cr.openjdk.java.net/~emc/8006345/webrev.04/src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java.sdiff.html, which added the second loop.

A fresh checkout reveals that only the second appendInt got converted to appendChar. The first appears to have been improperly merged. This obviously causes invalid MethodParameter attributes to be generated.

This patch corrects the problem by converting the first appendInt, as it should have been in 8006948.

The webrev is here: http://cr.openjdk.java.net/~emc/8008658/

Thanks, Eric -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 303 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130221/df559ece/eric_mccorkle.vcf

More information about the compiler-dev mailing list