Request for Review JDK-8006948: Update javac for MethodParameters format change (original) (raw)

Eric McCorkle eric.mccorkle at oracle.com
Fri Jan 25 11:31:22 PST 2013

On 01/25/13 13:54, Kumar Srinivasan wrote:

On 01/25/13 13:32, Kumar Srinivasan wrote: Eric,

Hello,

Please review this change, which updates javac and the classfile library to reflect changes in the class file format of MethodParameters attributes. What was the reason to make this change ? It was decided that the SYNTHESIZED flag would be 0x8000, not 0x10000 as it was in a previous version of the spec. Therefore, there is no reason for the flags field to be u4. Right I read the discussions on the rationale now. It bears mention that the u4 causes alignment trap issues if not handled carefully. Not true, this will break pack200. and there are tests in place for this. http://cr.openjdk.java.net/~ksrini/8005252/webrev.1/ What would it take to update these tests accordingly? I assume they are in TL, and thus can be addressed with a follow-up? Yes.

Honestly, the pack200 tests for this should be disabled for now. The unit tests aren't enabled at this point, because the implementation is under active testing and modification.

Should I include something in this patch to disable the test, or should it be done in a separate changeset? -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 314 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130125/d456a670/eric_mccorkle.vcf

More information about the compiler-dev mailing list