RFR: 8213908: AssertionError in DeferredAttr at setOverloadKind (original) (raw)
Maurizio Cimadamore maurizio.cimadamore at oracle.com
Tue Nov 20 17:52:14 UTC 2018
- Previous message: RFR: 8213908: AssertionError in DeferredAttr at setOverloadKind
- Next message: RFR: 8214026: Canonicalized archive paths appearing in diagnostics
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Ah right; approved
Maurizio
On 20/11/2018 17:47, Liam Miller-Cushon wrote:
On Tue, Nov 20, 2018 at 3:55 AM Maurizio Cimadamore <maurizio.cimadamore at oracle.com_ _<mailto:maurizio.cimadamore at oracle.com>> wrote:
Looks good; I also wonder if it should be relaxed in the other direction too - e.g. Assert.check(previous == ERROR || overloadKInd == ERROR || previous == overloadKind)
I think that's covered by the other branch of the if/else, we should only get to the assertion if previous != ERROR. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20181120/974cbf14/attachment.html>
- Previous message: RFR: 8213908: AssertionError in DeferredAttr at setOverloadKind
- Next message: RFR: 8214026: Canonicalized archive paths appearing in diagnostics
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]