review request for 6622432 (original) (raw)

Christian Thalinger Christian.Thalinger at Sun.COM
Tue Feb 17 13:51:53 UTC 2009

On Tue, 2009-02-17 at 14:20 +0100, Rémi Forax wrote:

> 1. Is bitCount() called often and performance critical? There is a RFE > (6378821) to intrinsify it and I am thinking about to implement it. > It's not related to BigInteger but the fastest multi-dispatch algorithm that I know relies heavily on bitCount too (on Long.bitCount). So you have my vote :)

Interesting, do you have a pointer to an example algorithm?

> 2. Why is BigInteger using it's own implementation of bit-count > (bitCnt()) instead of using Integer.bitCount()? > because Integer.bitCount() was introduced in 1.5 and BigInteger in 1.4. BigInteger was not retrofited.

Ohh, I missed that. Could someone fix that or should I propose a patch?

-- Christian

More information about the core-libs-dev mailing list