inefficient Des3DkCrypto/DigestMD5Base.setParityBit() (original) (raw)

Christian Thalinger Christian.Thalinger at Sun.COM
Tue Feb 17 14:59:51 UTC 2009


Hi!

While looking at the bitCount() thing I mentioned in the other thread, I noticed that Des3DkCrypto and DigestMD5Base are using a very inefficient implementation of setParityBit(). The one from DESKeyGenerator is much better and uses Integer.bitCount(), which could benefit from a population-count intrinsic.

Should I file a CR or even propose a patch?

-- Christian



More information about the core-libs-dev mailing list