hg: jdk7/tl/jdk: 6843578: Re-implement IBM doublebyte charsets; ... (original) (raw)

Ulf Zibis Ulf.Zibis at gmx.de
Fri May 22 22:37:32 UTC 2009

Am 22.05.2009 22:50, Xueming Shen schrieb:

Ulf Zibis wrote:

I think I have forgotten one thing: isisDoubleByte() in DoubleByte uses hard-wired values. Shouldn't they be better b1Min etc. ? These hardcoded values are explicitly specified by the "spec" of ebcdic doublebyte encoding. So I think it's fine to leave them hard-wired. Sherman

Ah, ok, I didn't know, that your DoubleByte class is exclusively designed for EBCDIC, I thought, it is base class for whatever double-byte encoding. So, being pedantic, it should be named DoubleByteEBCDIC (?)

Ulf

More information about the core-libs-dev mailing list