First round of java.util.Objects for code review (bug 6797535) (original) (raw)

Thu Oct 8 18:10:01 UTC 2009

   throw new AssertionError("No java.util.Objects instances for you!");
* Returns {@code true} if the arguments are equal to each other
* and {@code false} otherwise.
* Consequently, if both arguments are {@code null}, {@code true}
* is returned and if exactly one argument is {@code null}, {@code
* false} is returned.  Otherwise, equality is determined by using
* the {@link Object#equals equals} method of the first
* argument.
*
* @return {@code true} if the arguments are equal to each other
* and {@code false} otherwise
* @see Object#equals(Object)
*/
   return (a == b) || (a != null && a.equals(b));
* Returns the hash code of a non-{@code null} argument and 0 for
* a {@code null} argument.
*
* @return the hash code of a non-{@code null} argument and 0 for
* a {@code null} argument
* @see Object#hashCode
*/
   return o != null ? o.hashCode() : 0;
* Returns the result of calling {@code toString} for a non-{@code
* null} argument and {@code "null"} for a {@code null} argument.
*
* @return the result of calling {@code toString} for a non-{@code
* null} argument and {@code "null"} for a {@code null} argument
* @see Object#toString
* @see String#valueOf(Object)
*/
   return String.valueOf(o);
* Returns 0 if the arguments are identical and {@code
* c.compare(a, b)} otherwise.
* Consequently, if both arguments are {@code null} 0
* is returned.
*
* <p>Note that if one of the arguments is {@code null}, a {@code
* NullPointerException} may or may not be thrown depending on
* what ordering policy, if any, the {@link Comparator Comparator}
* chooses to have for {@code null} values.
*
* @return 0 if the arguments are identical and {@code
* c.compare(a, b)} otherwise.
* @see Comparable
* @see Comparator
*/
   return (a == b) ? 0 :  c.compare(a, b);
   int errors = 0;
   errors += testEquals();
   errors += testHashCode();
   errors += testToString();
   errors += testCompare();
   if (errors > 0 )
       throw new RuntimeException();
   int errors = 0;
   Object[] values = {null, "42", 42};
   for(int i = 0; i < values.length; i++)
       for(int j = 0; j < values.length; j++) {
           boolean expected = (i == j);
           Object a = values[i];
           Object b = values[j];
           boolean result = Objects.equals(a, b);
           if (result != expected) {
               errors++;
               System.err.printf("When equating %s to %s, got %b intead of %b%n.",
                                 a, b, result, expected);
           }
       }
   return errors;
   int errors = 0;
   errors += (Objects.hashCode(null) == 0 ) ? 0 : 1;
   String s = "42";
   errors += (Objects.hashCode(s) == s.hashCode() ) ? 0 : 1;
   return errors;
   int errors = 0;
   errors += ("null".equals(Objects.toString(null)) ) ? 0 : 1;
   String s = "Some string";
   errors += (s.equals(Objects.toString(s)) ) ? 0 : 1;
   return errors;
   int errors = 0;
   String[] values = {"e. e. cummings", "zzz"};
   String[] VALUES = {"E. E. Cummings", "ZZZ"};
   errors += compareTest(null, null, 0);
   for(int i = 0; i < values.length; i++) {
       String a = values[i];
       errors += compareTest(a, a, 0);
       for(int j = 0; j < VALUES.length; j++) {
           int expected = Integer.compare(i, j);
           String b = VALUES[j];
           errors += compareTest(a, b, expected);
       }
   }
   return errors;
   int errors = 0;
   int result = Objects.compare(a, b, String.CASE_INSENSITIVE_ORDER);
   if (Integer.signum(result) != Integer.signum(expected)) {
       errors++;
       System.err.printf("When comaping %s to %s, got %d intead of %d%n.",
                         a, b, result, expected);
   }
   return errors;