Code review request for 6648344: (reflect spec) State default of isAccessible for reflective objects (original) (raw)
Joseph D. Darcy Joe.Darcy at Sun.COM
Fri Oct 9 21:50:56 UTC 2009
- Previous message: Quick code review request for 634992 (enum) Include links from java.lang.Enum to EnumSet and EnumMap
- Next message: Code review request for 6648344: (reflect spec) State default of isAccessible for reflective objects
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hello.
Please review this simple specification clarification (with accompanying test) for 6648344: (reflect spec) State default of isAccessible for reflective objects
-Joe
--- old/src/share/classes/java/lang/reflect/AccessibleObject.java
2009-10-09 14:48:35.000000000 -0700
+++ new/src/share/classes/java/lang/reflect/AccessibleObject.java
2009-10-09 14:48:35.000000000 -0700
@@ -44,6 +44,8 @@
- as Java Object Serialization or other persistence mechanisms, to
- manipulate objects in a manner that would normally be prohibited.
By default, a reflected object is not accessible.
- @see Field
- @see Method
- @see Constructor --- /dev/null 2009-07-06 20:02:10.000000000 -0700 +++ new/test/java/lang/reflect/DefaultAccessibility.java 2009-10-09 14:48:36.000000000 -0700 @@ -0,0 +1,69 @@ +/*
- Copyright 2009 Sun Microsystems, Inc. All Rights Reserved.
- DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
- This code is free software; you can redistribute it and/or modify it
- under the terms of the GNU General Public License version 2 only, as
- published by the Free Software Foundation.
- This code is distributed in the hope that it will be useful, but WITHOUT
- ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
- version 2 for more details (a copy is included in the LICENSE file that
- accompanied this code).
- You should have received a copy of the GNU General Public License version
- 2 along with this work; if not, write to the Free Software Foundation,
- Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
- Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
- CA 95054 USA or visit www.sun.com if you need additional information or
- have any questions.
- */
- +/*
- @test
- @bug 6648344
- @summary Test that default accessibility is false
- @author Joseph D. Darcy
- */
- +import java.lang.reflect.*;
- +public class DefaultAccessibility {
- private DefaultAccessibility() {
super();
- }
- private static int f = 42;
- public static void main(String... args) throws Exception {
Class<?> daClass = (new DefaultAccessibility()).getClass();
int elementCount = 0;
for(Constructor<?> ctor : daClass.getDeclaredConstructors()) {
elementCount++;
if (ctor.isAccessible())
throw new RuntimeException("Unexpected accessibility
for constructor " +
ctor);
}
for(Method method : daClass.getDeclaredMethods()) {
elementCount++;
if (method.isAccessible())
throw new RuntimeException("Unexpected accessibility
for method " +
method);
}
for(Field field : daClass.getDeclaredFields()) {
elementCount++;
if (field.isAccessible())
throw new RuntimeException("Unexpected accessibility
for field " +
field);
}
if (elementCount < 3)
throw new RuntimeException("Expected at least three
members; only found " +
elementCount);
- }
+}
- Previous message: Quick code review request for 634992 (enum) Include links from java.lang.Enum to EnumSet and EnumMap
- Next message: Code review request for 6648344: (reflect spec) State default of isAccessible for reflective objects
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]