Review Request for 7116997 (warning cleanup java.util.PropertyPermission) (original) (raw)

Stuart Marks stuart.marks at oracle.com
Fri Dec 2 00:06:53 UTC 2011

On 12/1/11 1:18 PM, Brandon Passanisi wrote:

I have a webrev pertaining to the warning cleanup changes for java.util.PropertyPermission ready for review. Here's the info:

Bug: 7116997 Webrev: http://cr.openjdk.java.net/~dmocek/bpassanisi/7116997/webrev.00/ <http://cr.openjdk.java.net/%7Edmocek/bpassanisi/7116997/webrev.00/>

Hi Brandon,

Can you take out the @SuppressWarnings from the getMask() method, and change the /FALLTHROUGH/ comment at line 309 to "break" instead? I think this is equivalent code, and it will get rid of the warning message without having to suppress warnings.

thanks.

s'marks

More information about the core-libs-dev mailing list