7116957: javax.script.ScriptEngineManager should use java.util.ServiceLoader to lookup service providers (original) (raw)

Alan Bateman Alan.Bateman at oracle.com
Fri Dec 2 13:54:18 UTC 2011


On 02/12/2011 11:30, Chris Hegarty wrote:

Alan,

Would you mind taking a quick look at the updated webrev? Trivially, I fixed a few style issues in HttpServerProvider (a nit of mine) and updated the commented code in FtpClientProvider (in case it ever gets enabled ). Let's remove any possibility of sun.misc.Service every reappearing ;-) http://cr.openjdk.java.net/~chegar/7116957/webrev.01/webrev/ -Chris. Loos fine to me. In FtpClientProvider.java I would probably have just removed this code.

-Alan



More information about the core-libs-dev mailing list