Request for Review: Warnings cleanup in java.lang., java.util.* (original) (raw)

Omair Majid omajid at redhat.com
Fri Dec 2 17:00:29 UTC 2011

Hi,

On 12/02/2011 07:18 AM, Alan Bateman wrote:

cc'ing core-libs-dev as that is the place to discuss these changes. I see on the sign-up sheet [1] that omajid has signed up for java.lang, maybe you are working together?

Unfortunately, David and I were not working together :(

Anyway, here is my webrev for java.lang.* http://cr.openjdk.java.net/~omajid/webrevs/warnings-day-2011/01/

Sorry about the delay, building and testing this took longer than I had expected it to. Also, this patch only addresses the warnings pointed out by javac.

The classes java.lang.ThreadLocal and java.lang.ClassValue are not included in the webrev. The fixes for ThreadLocal were basically sprinkling @SuppressWarnings("unchecked") throughout and the fixes for ClassValue looked slightly more complex when I tried to reduce the use of rawtypes. I will post a separate webrev for those later.

Cheers, Omair

More information about the core-libs-dev mailing list