please review 7117612: warnings fixes in java.lang (original) (raw)

Stuart Marks stuart.marks at oracle.com
Mon Dec 5 01:02:46 UTC 2011

Please review the following webrev submitted by Omair Majid, consisting of warnings fixes for a variety of files in java.lang.

http://cr.openjdk.java.net/~omajid/webrevs/warnings-day-2011/01/

It looks pretty clean, but it would be good to get another pair of eyes on this since there is sometimes great subtlety in java.lang.

My comments below.

AutoCloseable.java --

 java/lang/AutoCloseable.java:34: warning: [try] auto-closeable
 resource AutoCloseable has a member method close() that could
 throw InterruptedException

The warning here is kind of silly. The intent is to warn implementors of AutoCloseable not to throw InterruptedException. But this is an interface, not an implementation, and it's the AutoCloseable interface itself! We may want to rethink when the compiler emits this warning, instead of suppressing the warning in source code. Joe, what do you think about this?

CharacterName.java --

Consider narrowing the scope of @SuppressWarnings by using a local variable.

Thanks,

s'marks

More information about the core-libs-dev mailing list