Request for Review: 7116914 (Miscellaneous warnings (sun.text)) (original) (raw)
Yuka Kamiya yuka.kamiya at oracle.com
Mon Dec 5 03:24:34 UTC 2011
- Previous message: Request for Review: 7116914 (Miscellaneous warnings (sun.text))
- Next message: Request for Review: 7116914 (Miscellaneous warnings (sun.text))
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi,
Mike, Stuart, Alan, and Masayoshi: Thank you for your comments.
If no one has any objections, I'd like to fix only
- The parens are probably not needed around 'length=(srcIndex-prevSrc);' pointed out by Mike.
Both the serialVersionUID of AttributedCharacterIterator.Attribute and breaks in UnicodeSet.java seem harmless.
I like Stuart's suggestion
case 1: ... throw syntaxError(...); but we have a local maintenance policy about these files imported from the third party. As long as the code works correctly (and doesn't issue a warning), smaller change is better. (The policy may change in the future, though.)
Thanks,
Yuka
(11/12/02 16:51), Yuka Kamiya wrote:
Hello,
Could someone please review this fix? http://cr.openjdk.java.net/~peytoia/7116914/webrev.00/ Some warnings are still issued even after this fix, and that's intentional. I'd like to solve them in another way rather than using @SuppressWarnings("deprecation") in the future. The original number of warnings in this area was 70. Now 16. Thanks, -- Yuka Kamiya
- Previous message: Request for Review: 7116914 (Miscellaneous warnings (sun.text))
- Next message: Request for Review: 7116914 (Miscellaneous warnings (sun.text))
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]