Answer requested!!! was: Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException (original) (raw)
Sean Mullan sean.mullan at oracle.com
Mon Dec 5 18:06:38 UTC 2011
- Previous message: Answer requested!!! was: Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException
- Next message: Answer requested!!! was: Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 12/2/11 11:02 AM, Sean Mullan wrote:
[0] Solution 1 http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/70118044/index.html [1] Solution 2 http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/70118046/index.html
I definitely prefer solution 2. Just a few minor comments:
Use the javadoc @inheritDoc tag instead of copying the javadoc for the initCause method.
PreventOverridingOfChaining
lines 68, 71: what do these comments mean?
one additional test that would be useful to add would be to call initCause twice for those ctors that don't have a Throwable parameter, and make sure initCause throws IllegalStateExc.
--Sean
- Previous message: Answer requested!!! was: Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException
- Next message: Answer requested!!! was: Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]