please review 7117612: warnings fixes in java.lang (original) (raw)

Alan Bateman Alan.Bateman at oracle.com
Thu Dec 8 08:23:36 UTC 2011

On 08/12/2011 06:22, Stuart Marks wrote:

Hi Omair, Everything looks good to me. I think Alan was lamenting that adding the local variable for the sole purpose of adding the @SuppressWarnings annotation makes the method appear longer and more complex. The alternative is to put @SuppressWarnings on the entire method, which we've consistently frowned on, so I don't see the need to change anything. By the way, I've also run this changeset through our internal multi-platform build and test system, and everything works fine (with the exception of intermittent failures unrelated to this change). You have commit rights, don't you? I'd say it's OK to proceed with the push. Or, if you prefer, Alan should be online in just a couple hours, and I'm sure he can give the final go-ahead. Yes, I'm okay with the latest webrev, I just lamenting about tiny increase in the method size and just concerned that it might impact inlining decisions.

-Alan

More information about the core-libs-dev mailing list