java.util patch for Warning Cleanup Day (original) (raw)

Rémi Forax forax at univ-mlv.fr
Fri Dec 9 00:01:48 UTC 2011

On 12/06/2011 10:29 PM, Mike Duigou wrote:

I have reviewed this patch and also run it against the java/util jtreg test. It looks good to me.

Some comments: Currency.java: - The current mercurial source has one of your changes but the remaining two changes, diamond and @SW are still valid. ResourceBundle: - This file also has changes in the current mercurial source. Your version, IMO, is an improvement over the mercurial version and should be applied. HashMap: -The changes to use wildcard instead of the type parameters are a bit disappointing but reasonable.

There is no good solution. At least this one is coherent for the whole file (and LinkedHashMap) and avoid warnings in equals, remove etc.

TreeSet: - The change to readObject() (using a single constructor) is theoretically outside of the scope of "warnings only" but I am OK with it.

I forget to mention that change. I found it was weird to have a nullcheck to call a constructor that accepts null.

Mike

Rémi

More information about the core-libs-dev mailing list