Add Look&Feel support for AIX platform (original) (raw)

Sean Chou zhouyx at linux.vnet.ibm.com
Wed Dec 14 08:00:18 UTC 2011

Thanks for the comment! I modified it according to your suggestion. The new version is here: http://cr.openjdk.java.net/~zhouyx/OJDK-167/webrev.00/

So will any oracle guy help create a bug and push it or give some additional comments so I can enhance the patch ?

On Wed, Dec 14, 2011 at 8:44 AM, Dr Andrew John Hughes <ahughes at redhat.com>wrote:

On 14:45 Tue 13 Dec , Neil Richards wrote: > On Tue, 2011-12-13 at 14:42 +0000, Neil Richards wrote: > > On Tue, 2011-12-13 at 10:36 +0800, Sean Chou wrote: > > > On Mon, Dec 12, 2011 at 7:33 PM, Neil Richards > > > <neil.richards at ngmr.net> wrote: > > > On Tue, 2011-12-06 at 11:14 +0800, Sean Chou wrote: > > > > Hi, > > > > > > > > > > > > I'm not sure what to do for it next, shall I create a bug > > > for it > > > > now ? But I > > > > don't think the bug system support AIX platform. I > > > remembered it > > > > would > > > > report something like "we are not supporting the platform". > > > > > > > > > > > > > Hi Sean, > > > Looking at the options available on the Java bug submission > > > site [1], it > > > looks like: > > > Release: OpenJDK > > > Operating System: Generic / Other > > > > > > would be the most appropriate choices to make. > > > > > > Regards, > > > Neil > > > > > > > > > -- > > > Unless stated above: > > > IBM email: neilrichards at uk.ibm.com > > > IBM United Kingdom Limited - Registered in England and Wales > > > with number 741598. > > > Registered office: PO Box 41, North Harbour, Portsmouth, > > > Hampshire PO6 3AU > > > > > I tried once, and it was dropped because "the platform is not > > > supported." > > > > > > -- > > > Best Regards, > > > Sean Chou > > > > > > > Hmm, in that case, perhaps someone from Oracle can help in creating a > > suitable Java bug id under which this change can be made? > > > > >From the OpenJDK census [1], I see that both Mario and I are currently > > "committers" in the jdk8 project. > > > > As jdk8 is under review control, I believe you'll need some affirmation > > from someone who is a "reviewer". > > > > Such a person is currently likely to be from Oracle, and so may be able > > to help in creating the associated bug id. > > > > Hope this helps. > > > > Regards, > > Neil > > > > Oops, forgot to give the trailed link to the OpenJDK census. > > Regards, Neil > > [1] http://openjdk.java.net/census > > -- > Unless stated above: > IBM email: neilrichards at uk.ibm.com > IBM United Kingdom Limited - Registered in England and Wales with number 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU >

This seems to have dragged on an unduly long time for such a simple patch. The patch looks good to me. The only minor point I'd make is that the comment '// determine another OS here' should probably be under where the AIX if block is added, not above it. According to the census, I have jdk8 reviewer status so this should count as a review. However, as we're still stuck with the antiquated bug system at present, we still need someone at Oracle to give it a bug ID. So if an Oracle employee would be so kind as to do so, this can finally be pushed. It's only about two months old... -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07

-- Best Regards, Sean Chou

More information about the core-libs-dev mailing list