Code Review 7000511: PrintStream, PrintWriter, Formatter leave files open when exception thrown (original) (raw)

Alan Bateman Alan.Bateman at oracle.com
Wed Jan 5 11:49:04 UTC 2011

Chris Hegarty wrote:

: Thanks for the comments. Please take a look at the latest changes. http://cr.openjdk.java.net/~chegar/7000511/webrev.02/webrev/ I see you've updated this to webrev.03 so I looked at that. Overall this looks much cleaner and you've addressed the issues that I pointed out.

One minor comment is that the coding style is bit inconsistent with the existing code in a few places. For example in methods that throw checked exceptions you've indented the "throws XYZ" much more than the existing code and the closing brace is pushed out which looks a bit strange compared to the existing code. Also the comment in toCharset (repeated in all classes) probably should be a one-liner with //.

-Alan.

More information about the core-libs-dev mailing list