Code Review Request - Bug #6948101 & 7142596: RMI JPRT tests are failing (original) (raw)

Alan Bateman Alan.Bateman at oracle.com
Thu Apr 19 10:50:25 UTC 2012

On 18/04/2012 21:39, Darryl Mocek wrote:

:

Brilliant! I didn't realize Registry.toString included the port number. However, I did in fact find a way to get the port through the API's (see below), although I think toString is more efficient. I'm pretty sure I can get rid of the instanceof checks. I don't have a strong opinion as to whether it uses toString or depends on sun.rmi.server.RegistryImpl. The main thing is that I think it will be a lot more reliable to bind to an ephemeral port when compared to find an unused port.

Just so you know, I grabbed the patch from your webrev and tried it out, it was nice to see close to x4 improvement when running these tests with -concurrency:auto on an 4-core system.

-Alan

More information about the core-libs-dev mailing list