Remove the assert in Integer.valueOf() (original) (raw)
Mario Torre neugens.limasoftware at gmail.com
Mon Apr 23 17:43:39 UTC 2012
- Previous message: Remove the assert in Integer.valueOf()
- Next message: Remove the assert in Integer.valueOf()
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
2012/4/23 Rémi Forax <forax at univ-mlv.fr>:
The issue is that Hotspot also count the bytecodes related to assert in its inlining heuristic. If the assert is commented, the inlining tree is good.
[...]
Given that Integer.valueOf() is a method used very often and that if the inlining fails, the escape analysis will not remove the allocation, I think it's a good idea to comment this assert.
Hi Rémi,
I'm not sure if it's a good idea or not to remove the assert.
What happens if we replace the assert with a specific check, is it still not inlined?
Cheers, Mario
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF Fingerprint: BA39 9666 94EC 8B73 27FA FC7C 4086 63E3 80F2 40CF
IcedRobot: www.icedrobot.org Proud GNU Classpath developer: http://www.classpath.org/ Read About us at: http://planet.classpath.org OpenJDK: http://openjdk.java.net/projects/caciocavallo/
Please, support open standards: http://endsoftpatents.org/
- Previous message: Remove the assert in Integer.valueOf()
- Next message: Remove the assert in Integer.valueOf()
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]