Please review: 7151434: java -jar -XX crashes java launcher (original) (raw)
Joe Darcy joe.darcy at oracle.com
Tue Apr 24 15:54:29 UTC 2012
- Previous message: Please review: 7151434: java -jar -XX crashes java launcher
- Next message: hg: jdk8/tl/jdk: 7151434: java -jar -XX crashes java launcher
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Kumar,
The launcher changes looks fine, but I recommend generally documenting the null-handling protocol in these sort of functions. We generally don't include bug ids in the next of the test, but I see the test file does that in other areas.
Cheers,
-Joe
On 04/24/2012 08:24 AM, Kumar Srinivasan wrote:
Hi,
Could you please review this, actually the launcher is a 2 line change, but when I was testing/experimenting with this, it was hard to inspect the .jtr file for test failure, the test framework is cleanup to help the reader quickly identify the failing test cases. http://cr.openjdk.java.net/~ksrini/7151434 Thanks Kumar
- Previous message: Please review: 7151434: java -jar -XX crashes java launcher
- Next message: hg: jdk8/tl/jdk: 7151434: java -jar -XX crashes java launcher
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]