Code Review Request: 7118100: Inconsistency when using system and user preference on OSX Lion (original) (raw)
Kurchi Hazra kurchi.subhra.hazra at oracle.com
Thu Apr 26 17:31:20 UTC 2012
- Previous message: Code Review Request: 7118100: Inconsistency when using system and user preference on OSX Lion
- Next message: Review Request: 7164376 Replace use of sun.security.action.LoadLibraryAction
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Thanks Alan for the thumbs up.
I filed 7164636 for the cleanup.
- Kurchi
On 4/26/2012 12:18 AM, Alan Bateman wrote:
On 26/04/2012 01:34, Kurchi Hazra wrote:
Hi,
While syncing user preferences, a BackingStoreException is not expected, since the current user should be able to read/write such preferences to the persistent storage (unlike system preferences, where current user needs to have admin rights). This fix aims at allowing a user preference node to sync any changes to the persistent storage. Bug: http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7118100 Webrev: http://cr.openjdk.java.net/~khazra/7118100/jdk8/webrev.00/ This webrev had been earlier code-reviewed for 7u4(but never committed) [1]. There are no additional changes required for jdk8. Thanks, Kurchi [1] http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-February/003081.html Kurchi - this looks fine to me. As per exchange on macosx-dev there is some clean-up to do in this code, including raw type warnings and we should make sure we have a bug to remember this. -Alan
-- -Kurchi
- Previous message: Code Review Request: 7118100: Inconsistency when using system and user preference on OSX Lion
- Next message: Review Request: 7164376 Replace use of sun.security.action.LoadLibraryAction
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]