PING: [PATCH FOR REVIEW] System Zlib Support (original) (raw)

Alan Bateman Alan.Bateman at oracle.com
Fri Aug 3 11:20:57 UTC 2012

On 02/08/2012 19:31, Andrew Hughes wrote:

:

Ok, I thought that's what you were aiming at. That wouldn't solve the problem for us. We can't include a version of zlib in OpenJDK. It violates distribution policies and means security updates have to be applied in two places. We've been carrying patches for zlib (and jpeg, png, etc.) for years to avoid this. Our build actually deletes the source files before building to ensure this doesn't happen. As you know, we can't delete the zlib code as we still need it for other platforms, Windows mostly. From a brief scan of your patch (not a detailed review, too busy at the moment) then it looks like you've added a SYSTEM_ZLIB option to select (at build-time) whether to compile the version in the jdk repository or not. This approach make sense to me and should be separated from the changes needed to use an alternatively named zlib (which I think is what Intel IPP will require, assuming it can't be picked up by setting LD_LIBRARY_PATH).

In any case, I think both efforts require 7188852 and I see Sherman has a review out on that.

-Alan.

More information about the core-libs-dev mailing list