PING: [PATCH FOR REVIEW] System Zlib Support (original) (raw)

Xueming Shen xueming.shen at oracle.com
Mon Aug 6 05:40:02 UTC 2012

On 8/5/2012 2:00 PM, Alan Bateman wrote:

On 03/08/2012 19:33, Andrew Hughes wrote:

: http://cr.openjdk.java.net/~andrew/syslibs/zlib/webrev.02/

is an updated version which checks if ZLIBLIBS is set on Solaris, GNU/Linux and MacOS X and sets it to -lz if not. I wasn't sure what to do with Windows but something can be added there if necessary. Thanks for the update, it looks right to me now. To double check I did a quick build+test on all platforms with latest jdk8/tl + your patch and I don't see any issues. Now I'm wondering whether we should just bite the bullet and default SYSTEMZLIB to true on Linux, maybe Solaris too (Sherman - can you think of any reasons not to do this? It would avoid needing to put in a means to switch zlib at startup as it could be done simply with LDLIBRARYPATH). -Alan.

I'm still on a very old ubuntu (9.1) so I might be wrong. Does the pkg-config --cflags/libs assume the zlib-dev or some similar dev package to be installed? pkg-config says I don't have it installed, so the cflags does not get set correctly. It appears at least one ubuntu12 machine has the same situation. So I guess at least we will have to add something into the "build readme" to add this package, if it is not installed by default.

I don't have a Solaris machine for a while, so just wonder if the zlib always get installed by default installation these days?

-Sherman

More information about the core-libs-dev mailing list