PING: [PATCH FOR REVIEW] System Zlib Support (original) (raw)

Xueming Shen xueming.shen at oracle.com
Mon Aug 6 18:59:26 UTC 2012

On 08/06/2012 11:26 AM, Andrew Hughes wrote:

----- Original Message -----

Hi Andrew,

I meant if we are going to put SYSTEMZLIB=true as default for linux as Alan suggested, we might need to update the build document as well to include zlib-dev as the "necessary" package to build jdk on linux. Ok. I think that's a separate issue which warrants a separate bug& changeset. Let's have this one work on fixing the build so SYSTEMZLIB actually works on GNU/Linux first. At the moment, enabling SYSTEMZLIB=true breaks the build on anything other than MacOS/X, which seems like a bug to me.

It's a separate issue. For your current patch, since it does not set the SYSTEM_ZLIB=true for linux, it's not an issue at all. My apology for my naive question, is zlib (the library) always installed by default by most linux distributors?

Currently the SYSTEMZLIB=true is set in make/common/Defs-macosx.gmk. Ok, so it's the default there already. That explains the defines.h logic.

ZLIBVERSION = 1.2.5 is setin make/common/Defs.gmk. What's the relevance of this version? My system install is 1.2.7.

That's the version bundled with jdk. Yes, 1.2.7 is the latest, out May/2012. I might try to upgrade the bundled one to the latest version at later stage of jdk8. The "relevance" is that they are all used for "zlib build", so it would be better to put them together/close for future maintenance, though some comment might be necessary to clarify one is for "bundled" version, on is for the link options for os zlib.

-sherman

More information about the core-libs-dev mailing list