[PATCH FOR REVIEW] Potential Buffer Overflow in java_props_md.c (original) (raw)
Andrew Hughes ahughes at redhat.com
Wed Aug 8 11:40:08 UTC 2012
- Previous message: [PATCH FOR REVIEW] Potential Buffer Overflow in java_props_md.c
- Next message: [PATCH FOR REVIEW] Potential Buffer Overflow in java_props_md.c
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
----- Original Message -----
On 08/08/2012 01:33, David Holmes wrote: > On 8/08/2012 2:40 AM, Xueming Shen wrote: >> >> Andrew, >> >> Since we are here:-) are we also supposed to "free" the oldtemp >> at #250 >> and oldtemp and oldev at the end? > > No. They are aliases for temp and encodingvariant, which are freed > at > the end. There are only ever at most two things to free. > > Andrew: this is fine by me, but needs TL approval (Alan?) You are a reviewer on the jdk8 project so Andrew should be all set. In any case, the update looks good to me too.
-Alan.
Looks like we all are, from the census :-)
Pushed: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d87e86aaf2b3
Thanks everyone!
Andrew :)
Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com)
PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
- Previous message: [PATCH FOR REVIEW] Potential Buffer Overflow in java_props_md.c
- Next message: [PATCH FOR REVIEW] Potential Buffer Overflow in java_props_md.c
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]