PING: [PATCH FOR REVIEW] System Zlib Support (original) (raw)
Andrew Hughes ahughes at redhat.com
Thu Aug 9 13:31:39 UTC 2012
- Previous message: PING: [PATCH FOR REVIEW] System Zlib Support
- Next message: PING: [PATCH FOR REVIEW] System Zlib Support
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
----- Original Message -----
On 08/06/2012 11:26 AM, Andrew Hughes wrote: > ----- Original Message ----- >> Hi Andrew, >> >> I meant if we are going to put SYSTEMZLIB=true as default for >> linux >> as >> Alan suggested, >> we might need to update the build document as well to include >> zlib-dev >> as the "necessary" >> package to build jdk on linux. > Ok. I think that's a separate issue which warrants a separate bug& > changeset. Let's have this one work on fixing the build so > SYSTEMZLIB > actually works on GNU/Linux first. At the moment, enabling > SYSTEMZLIB=true > breaks the build on anything other than MacOS/X, which seems like a > bug to me.
It's a separate issue. For your current patch, since it does not set the SYSTEMZLIB=true for linux, it's not an issue at all. My apology for my naive question, is zlib (the library) always installed by default by most linux distributors? >> Currently the SYSTEMZLIB=true is set in >> make/common/Defs-macosx.gmk. > Ok, so it's the default there already. That explains the defines.h > logic. > >> ZLIBVERSION = 1.2.5 is setin make/common/Defs.gmk. > What's the relevance of this version? My system install is 1.2.7. That's the version bundled with jdk. Yes, 1.2.7 is the latest, out May/2012. I might try to upgrade the bundled one to the latest version at later stage of jdk8. The "relevance" is that they are all used for "zlib build", so it would be better to put them together/close for future maintenance, though some comment might be necessary to clarify one is for "bundled" version, on is for the link options for os zlib. -sherman
Just checking on the status of this.
Am I ok to push:
http://cr.openjdk.java.net/~andrew/syslibs/zlib/webrev.02/
as #7110151 to tl?
Once that's in and system zlib support is working, we can decide whether to turn it on by default.
Thanks,
Andrew :)
Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com)
PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
- Previous message: PING: [PATCH FOR REVIEW] System Zlib Support
- Next message: PING: [PATCH FOR REVIEW] System Zlib Support
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]