Please Review: 6984084 (str) n times repetition of character constructor for java.lang.String (original) (raw)
Mike Duigou mike.duigou at oracle.com
Tue Aug 21 22:04:00 UTC 2012
- Previous message: Please Review: 6984084 (str) n times repetition of character constructor for java.lang.String
- Next message: Please Review: 6984084 (str) n times repetition of character constructor for java.lang.String
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
I'm still wondering if this functionality is really needed.
AbstractStringBuilder/String/StringBuffer/StringBuilder::
- You'll need to escape the "<" in the javadoc as either < or {@literal <}.
StringBuffer/StringBuilder::
- Is an additional {@inheritDoc} not needed?
Repeat/AppendIntCharSequence::
- Tests should not have the classpatch exception license.
Mike
On Aug 21 2012, at 13:45 , Jim Gish wrote:
Please review http://cr.openjdk.java.net/~jgish/6984084-jdk8-StringRepeat/ <http://cr.openjdk.java.net/%7Ejgish/6984084-jdk8-StringRepeat/>
This started in lambda, making changes to both StringJoiner and String. However, the dependence of String.repeat() on StringJoiner has been removed and the resulting non-lambda classes moved here for review. There will be a separate change and review for the StringJoiner changes in lamda-dev. Thanks, Jim
- Previous message: Please Review: 6984084 (str) n times repetition of character constructor for java.lang.String
- Next message: Please Review: 6984084 (str) n times repetition of character constructor for java.lang.String
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]