[PATCH] Review request: 6962637 TEST_BUG: java/io/File/MaxPathLength.java may fail in busy system (original) (raw)

Alan Bateman Alan.Bateman at oracle.com
Wed Aug 22 10:01:23 UTC 2012

On 22/08/2012 08:54, Eric Wang wrote:

Hi,

Please help to review the fix below for bug 6962637 <http://monaco.us.oracle.com/detail.jsf?cr=6962637> TESTBUG: java/io/File/MaxPathLength.java may fail in busy system http://dl.dropbox.com/u/90659131/fixes/6962637/webrev/index.html Root cause is the test is not reliable when system is busy, if disk space is changed by some other program, test can fail. so the fix is to check file.length() instead of disk space. Thanks for liberating another test, I remember that used to fail regularly when there was other activity on the system (or when running with -concurrency:auto where there are tests running concurrently).

I see you are exchanges mails with David about the dir.length check that you have added. I don't think it make sense and that check should be removed.

-Alan.

More information about the core-libs-dev mailing list