Review Request: 7193339 Prepare system classes be defined by a non-null module loader (original) (raw)
Mandy Chung mandy.chung at oracle.com
Fri Aug 24 22:57:48 UTC 2012
- Previous message: Review Request: 7193339 Prepare system classes be defined by a non-null module loader
- Next message: Review Request: 7193339 Prepare system classes be defined by a non-null module loader
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 8/24/2012 3:44 PM, David Holmes wrote:
My other query with these changes is whether we are certain that using the specified loader rather than the boot loader will always be correct.
Yes I'm to my best knowledge but I'm looking to the reviewers to tell me otherwise :)
The class being loaded is either part of the same module or expressed in its module dependency. I ran the JCK tests in module mode with the jigsaw modular JDK that uncovered these files to be changed. There are other places in the JDK that I didn't touch since they were not found by my testing.
BTW, I have created a new CR: 7194006: A new Class.forName(String cn, boolean initialize) method
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/7193339/webrev.02/
This include Paul's suggestion and slightly improved the javadoc for Class.forName you suggested [1]:
* @param initialize whether the class must be initialized
* @param initialize if {@code true} the class will be initialized.* See Section 12 of <em>The Java Language
Specification.
Thanks Mandy [1] http://mail.openjdk.java.net/pipermail/jigsaw-dev/2012-May/002534.html
- Previous message: Review Request: 7193339 Prepare system classes be defined by a non-null module loader
- Next message: Review Request: 7193339 Prepare system classes be defined by a non-null module loader
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]