Review Request: 7193406 - Clean-up JDK Build Warnings in java.util, java.io (original) (raw)

Ulf Zibis Ulf.Zibis at CoSoCo.de
Wed Aug 29 11:59:24 UTC 2012

Am 29.08.2012 07:22, schrieb Dan Xu:

It is funny. :) I have searched all source codes under jdk and removed spaces for the similar cases.

Please review the new version of change at, http://cr.openjdk.java.net/~dxu/7193406/webrev.03/. Thanks for your comment!

In class j.u.Collections you have added some @Override annotations. Why don't you add them in all appropriate cases and in all classes of your CR?

As they are not very frequent in the JDK, I think we should leave it as it is or write a script, which patches the whole JDK in one chunk.

-Ulf

More information about the core-libs-dev mailing list