RFR: 8003596 CheckLockLocationTest-Windows-fix (original) (raw)
Alan Bateman Alan.Bateman at oracle.com
Tue Dec 4 11:28:08 UTC 2012
- Previous message: RFR: 8003596 CheckLockLocationTest-Windows-fix
- Next message: RFR: 8003596 CheckLockLocationTest-Windows-fix
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 03/12/2012 15:01, Jim Gish wrote:
Thanks. Could you please push the change.
Jim I assume you also need to remove it from the exclude list (otherwise it will not run)?
Also did you consider using !isWindows() rather than !ON_WINDOWS, I think it would be neater. Better again would be just handle setWritable returning false, then you wouldn't to do anything Windows specific.
-Alan.
- Previous message: RFR: 8003596 CheckLockLocationTest-Windows-fix
- Next message: RFR: 8003596 CheckLockLocationTest-Windows-fix
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]