Request for Review: CR#8001667, second attempt (original) (raw)
Henry Jen henry.jen at oracle.com
Thu Dec 6 06:57:23 UTC 2012
- Previous message: hg: jdk8/tl/jdk: 8004317: TestLibrary.getUnusedRandomPort() fails intermittently, but exception not reported
- Next message: Request for Review: CR#8001667, second attempt
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi,
This update reflect changes based on feedbacks for last version, the changes are
- rename reverse() to reverseOrder()
- rename Comparator.compose to Comparator.thenComparing
- add 4 Comparator.thenComparing methods take [Int|Long|Double]Function to enable fluent syntax like this example,
people.sort(Comparators.comparing(People::getFirstName).thenComparing(People.getLastName))
vs previously,
people.sort(Comparators.comparing(Person::getName)) Comparator byLastFirst = Comparators.comparing(Person::getLastName) .compose(Comparators.comparing(Person::getFirstName))
Please review and comment on the webrev[1] and specdiff[2].
[1] http://cr.openjdk.java.net/~henryjen/ccc/8001667.1/webrev [2] http://cr.openjdk.java.net/~henryjen/ccc/8001667.1/specdiff/overview-summary.html
Cheers, Henry
- Previous message: hg: jdk8/tl/jdk: 8004317: TestLibrary.getUnusedRandomPort() fails intermittently, but exception not reported
- Next message: Request for Review: CR#8001667, second attempt
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]