RFR: 8003246: Add Supplier to ThreadLocal (original) (raw)

Remi Forax forax at univ-mlv.fr
Fri Dec 7 15:46:34 UTC 2012

On 12/07/2012 04:34 PM, Chris Hegarty wrote:

I filed 8004707: "Remove superfluous access$000 methods in java.util", to track this issue. I can file a separate issue for java.lang.

yes, please do that.

I'm sure there are other ways, but a simple find reports them: :>pwd build/solaris-i586/classes/java/util :> find . -name "*.class" -exec javap -v {} ; | grep '.access$00'

Technically, javac also generate constructor accessors that doesn't start by access00 but this should catch most of the generated accessors.

once changeset for 8003246 will be pushed, I will send two patches one for java.lang and one for java.util.

-Chris

Rémi

On 07/12/2012 14:27, Doug Lea wrote: On 12/06/12 18:44, Remi Forax wrote:

BTW, at some point, it will be a good idea to get ride of all these method access$000 in java.lang/java.util at least.

Maybe this is out of scope for this CR, but while in the neighborhood of ThreadLocal, it could be done here. There are a couple of annoying ones that kick in on any compile of anything involving ThreadLocals (try running with -XX:+PrintCompilation). To remove, replace "private" with "final" for methods, and just kill "private" for fields. -Doug

More information about the core-libs-dev mailing list