RFR: JDK-8003890: modify test scripts to pass VMOPTIONS (original) (raw)

Chris Hegarty chris.hegarty at oracle.com
Mon Dec 10 11:33:39 UTC 2012

On 10/12/2012 11:25, Alan Bateman wrote:

On 10/12/2012 11:13, Chris Hegarty wrote:

Thank you Mark, this is a really useful contribution.

I noticed that a few tests (below) specify either -client or -server. If the vmoptions contain either of these arguments, and this seems to be the way our test/Makefile is passing them, then it may result in the test using the wrong vm. I think we should remove TESTVMOPTS from these tests, but then we lose other potential opts, like heap size, etc. java/rmi/reliability/benchmark/runRmiBench.sh java/rmi/reliability/benchmark/runSerialBench.sh sun/management/jmxremote/startstop/JMXStartStopTest.sh You're right, this will cause conflict. In the case of JMXStartStopTest.sh and runSerialBench.sh then it might be better to remove the -server.

Agreed. I see no reason for specifying the vm. TESTVMOPTS will give us better coverage.

Stuart might have an opinion on runRmiBench.sh but one idea is to change is so that when run interactively (TESTJAVA not set) then it works as it does now and runs the benchmark twice. If TESTJAVA is not set then it runs the benchmark once, with whatever VM options are in use.

Sounds reasonable.

-Chris.

-Alan

More information about the core-libs-dev mailing list