8004874: (profiles) Reduce dependency on java.beans to only add/removePropertyChangeListener (original) (raw)

Alan Bateman Alan.Bateman at oracle.com
Wed Dec 12 10:47:21 UTC 2012

On 11/12/2012 22:18, Kumar Srinivasan wrote:

Alan,

PropMap.java, Nit: typo PropertyChangeListern's similarly in the other. Thanks, I'll fix that typo in the comment before I push the changes.

Nice test, but since it is specific to pack200 and all pack200 tests are in jdk/test/tools/pack200, perhaps move it there ? The reason I proposed it for java/util/jar/Pack200 is because it's an API test rather than a tool test. I don't mind moving it to tools/pack200 of course. I should also say that I'm not planning to push this test with the change, instead this goes with the update to Pack200 that requires javadoc changes for profiles so I'll push it to the profiles forest first.

Besides that I could not find anything else wrong, the users of these ProperyChangeListeners are the deployment technologies, though. Thanks for reviewing (also thanks Mandy and David).

-Alan.

More information about the core-libs-dev mailing list